Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: state listener observe writes at wrong time #13516

Merged
merged 30 commits into from
Dec 2, 2022
Merged
Show file tree
Hide file tree
Changes from 21 commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
ac86866
fix: state listener observe writes at wrong time
yihuang Oct 12, 2022
cfc62ff
synchronous abci call, and format doc
yihuang Nov 27, 2022
faa1f62
fix comment
yihuang Nov 27, 2022
473a066
update file streamer readme and fix typos
yihuang Nov 27, 2022
3e78836
typo
yihuang Nov 27, 2022
94591f3
fix: state listener observe writes at wrong time
yihuang Oct 12, 2022
9d4b776
improve UX of file streamer, make it immediately usable after enabled
yihuang Nov 28, 2022
1ee67d8
Merge remote-tracking branch 'fork/fix-listener-main3' into fix-liste…
yihuang Nov 28, 2022
25ce3af
get homePage from opts
yihuang Nov 28, 2022
2ca7afc
Merge branch 'main' into fix-listener-main3
tac0turtle Nov 28, 2022
135aaaf
Merge branch 'main' into fix-listener-main3
yihuang Nov 29, 2022
eff8761
Merge remote-tracking branch 'origin/main' into fix-listener-main3
yihuang Nov 29, 2022
b168d6f
fix merge
yihuang Nov 29, 2022
d310a03
use fmt.Errorf
yihuang Nov 29, 2022
c752120
Update CHANGELOG.md
yihuang Nov 29, 2022
4a2f933
Update CHANGELOG.md
yihuang Nov 29, 2022
43ae889
Merge branch 'main' into fix-listener-main3
yihuang Nov 29, 2022
ce17fe6
Merge branch 'main' into fix-listener-main3
yihuang Nov 30, 2022
b7e5c4a
Merge branch 'main' into fix-listener-main3
tac0turtle Nov 30, 2022
33d5ca9
Merge branch 'main' into fix-listener-main3
tac0turtle Nov 30, 2022
f583c69
Merge branch 'main' into fix-listener-main3
yihuang Nov 30, 2022
932680b
fix unit test
yihuang Nov 30, 2022
4fa2fbb
type assertion -> type conversion
yihuang Dec 1, 2022
e312225
update changelog about error propogation
yihuang Dec 1, 2022
23e3f9b
Update CHANGELOG.md
yihuang Dec 1, 2022
c5dbfd5
Merge branch 'main' into fix-listener-main3
yihuang Dec 1, 2022
d14c4ae
Merge branch 'main' into fix-listener-main3
tac0turtle Dec 2, 2022
c5d5408
Merge branch 'main' into fix-listener-main3
tac0turtle Dec 2, 2022
20aa3f7
Merge branch 'main' into fix-listener-main3
tac0turtle Dec 2, 2022
3559e7d
Merge branch 'main' into fix-listener-main3
tac0turtle Dec 2, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,12 @@ extension interfaces. `module.Manager.Modules` is now of type `map[string]interf
* (x/auth)[#13780](https://github.com/cosmos/cosmos-sdk/pull/13780) Querying with `id` (type of int64) in `AccountAddressByID` grpc query now throws error, use account-id(type of uint64) instead.
* (snapshots) [14048](https://github.com/cosmos/cosmos-sdk/pull/14048) Move the Snapshot package to the store package. This is done in an effort group all storage related logic under one package.
* (baseapp) [#14050](https://github.com/cosmos/cosmos-sdk/pull/14050) refactor `ABCIListener` interface to accept go contexts
* (store) [#13516](https://github.com/cosmos/cosmos-sdk/pull/13516) Update State Streaming APIs:
* Add method `ListenCommit` to `ABCIListener`
* Move `ListeningEnabled` and `AddListener` methods to `CommitMultiStore`
* Remove `CacheWrapWithListeners` from `CacheWrap` and `CacheWrapper` interfaces
* Remove listening APIs from the caching layer (it should only listen to the `rootmulti.Store`)
* Add three new options to file streaming service constructor

### CLI Breaking Changes

Expand Down Expand Up @@ -214,6 +220,7 @@ extension interfaces. `module.Manager.Modules` is now of type `map[string]interf
* (x/auth) [#13877](https://github.com/cosmos/cosmos-sdk/pull/13877) Handle missing account numbers during `InitGenesis`.
* (x/gov) [#13918](https://github.com/cosmos/cosmos-sdk/pull/13918) Fix propagation of message errors when executing a proposal.
* (baseapp)[#14049](https://github.com/cosmos/cosmos-sdk/pull/14049) Fix state sync when interval is zero.
* (store) [#13516](https://github.com/cosmos/cosmos-sdk/pull/13516) Fix state listener that was observing writes at wrong time.

### Deprecated

Expand Down
Loading