-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Check BeginBlock, Endblock extensions #13560
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #13560 +/- ##
==========================================
- Coverage 54.11% 53.87% -0.25%
==========================================
Files 652 645 -7
Lines 56062 55863 -199
==========================================
- Hits 30339 30094 -245
- Misses 23277 23345 +68
+ Partials 2446 2424 -22
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Can we do that for all modules? (f.e. add both BeginBlockAppModule and EndBlockAppModule for staking)
bd2776f
to
5743f04
Compare
Updated. |
Can you please rebase? Or allow us to update your fork. |
5743f04
to
8997619
Compare
Description
BeginBlock, Endblock extension introduced in #12603
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change