Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Check BeginBlock, Endblock extensions #13560

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

giansalex
Copy link
Contributor

@giansalex giansalex commented Oct 16, 2022

Description

BeginBlock, Endblock extension introduced in #12603


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Oct 16, 2022

Codecov Report

Merging #13560 (5743f04) into main (3c9b244) will decrease coverage by 0.24%.
The diff coverage is n/a.

❗ Current head 5743f04 differs from pull request most recent head 8997619. Consider uploading reports for the commit 8997619 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #13560      +/-   ##
==========================================
- Coverage   54.11%   53.87%   -0.25%     
==========================================
  Files         652      645       -7     
  Lines       56062    55863     -199     
==========================================
- Hits        30339    30094     -245     
- Misses      23277    23345      +68     
+ Partials     2446     2424      -22     
Impacted Files Coverage Δ
x/authz/module/module.go 17.94% <ø> (ø)
x/capability/module.go 66.19% <ø> (ø)
x/evidence/module.go 47.22% <ø> (ø)
x/feegrant/module/module.go 15.38% <ø> (ø)
x/group/module/module.go 51.89% <ø> (ø)
x/mint/module.go 66.30% <ø> (ø)
x/slashing/module.go 59.77% <ø> (ø)
x/staking/module.go 58.97% <ø> (ø)
x/upgrade/module.go 28.35% <ø> (ø)
x/slashing/keeper/msg_server.go 61.29% <0.00%> (-21.32%) ⬇️
... and 20 more

Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can we do that for all modules? (f.e. add both BeginBlockAppModule and EndBlockAppModule for staking)

@giansalex
Copy link
Contributor Author

giansalex commented Oct 16, 2022

Updated.

@julienrbrt
Copy link
Member

Can you please rebase? Or allow us to update your fork.

@giansalex giansalex force-pushed the begin-end-block-ext branch from 5743f04 to 8997619 Compare October 17, 2022 00:08
@julienrbrt julienrbrt enabled auto-merge (squash) October 17, 2022 07:40
@julienrbrt julienrbrt merged commit 18d8b64 into cosmos:main Oct 17, 2022
@giansalex giansalex deleted the begin-end-block-ext branch October 17, 2022 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants