RESTful governance endpoints #1357
Conversation
|
Something weird happening in the CI. Says authentication required to pull from the docker repo |
|
@rigelrozanski How do I get it to rerun the circle tests? |
|
If you force push to your current branch, that may refresh it. Otherwhise, merge in develop, or rerun the tests manually. (Click on details for each test, then rerun via ssh in the top right) |
x/gov/client/rest/rest.go
Outdated
| bechVoterAddr := vars[RestVoter] | ||
|
|
||
| if len(strProposalID) == 0 { | ||
| w.WriteHeader(http.StatusBadRequest) | ||
| // w.WriteHeader(http.StatusBadRequest) |
There was a problem hiding this comment.
Do we not need these headers?
There was a problem hiding this comment.
Oh oops, commented these out for some debugging thing. Will uncomment them
| // REST | ||
|
|
||
| // Rest Deposits | ||
| type DepositRest struct { |
There was a problem hiding this comment.
Let's come up with a naming schema for REST output
There was a problem hiding this comment.
pulling in @cwgoes @rigelrozanski
|
Looks pretty nice :) |
|
@ValarDragon Did you figure out the CI problem? |
Codecov Report
@@ Coverage Diff @@
## develop #1357 +/- ##
===========================================
- Coverage 63.78% 63.72% -0.07%
===========================================
Files 109 109
Lines 6028 6034 +6
===========================================
Hits 3845 3845
- Misses 1964 1970 +6
Partials 219 219 |
x/gov/depositsvotes.go
Outdated
|
|
||
| // Turn any Deposit to a DepositRest | ||
| func DepositToRest(deposit Deposit) DepositRest { | ||
| bechAddr, _ := sdk.Bech32ifyAcc(deposit.Depositer) |
| @@ -264,7 +264,7 @@ func (keeper Keeper) AddDeposit(ctx sdk.Context, proposalID int64, depositerAddr | |||
| // Add or update deposit object | |||
| currDeposit, found := keeper.GetDeposit(ctx, proposalID, depositerAddr) | |||
| if !found { | |||
| newDeposit := Deposit{depositerAddr, depositAmount} | |||
| newDeposit := Deposit{depositerAddr, proposalID, depositAmount} | |||
There was a problem hiding this comment.
Why do we need to store a copy of the proposal ID in each deposit? Can't we retrieve it from the key?
There was a problem hiding this comment.
No. Technically we don't even need to to store the depositerAddr either.
…into sunny/governance_rest
* get deposit rest endpoint * query proposals * changelog * fixed commented out headers * fixed undeterministic tests * increase circle test timeout * MustBech32ifyAcc * asdf
closes #1284