-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add documentation about depinject and app wiring #13683
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #13683 +/- ##
==========================================
- Coverage 56.66% 54.81% -1.85%
==========================================
Files 636 647 +11
Lines 54552 55798 +1246
==========================================
- Hits 30911 30588 -323
- Misses 21134 22722 +1588
+ Partials 2507 2488 -19
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, just need to rebase. Might need another set of eyes that have more context to complete the approval process
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome, thank you for making these doc updates! Just some minor nits.
Co-authored-by: Matt Kocubinski <mkocubinski@gmail.com>
Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com>
Description
Closes: #12633
app (building-apps/...)
app.go
(short explanation of the changes, linking to tutorials otherwise)app_config.go
and as alternativeapp.yaml
modules (building-modules/depinject)
module.proto
module.go
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change