-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Evidence API does not decode the hash properly #13740
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #13740 +/- ##
==========================================
+ Coverage 55.87% 56.03% +0.16%
==========================================
Files 656 646 -10
Lines 57164 55790 -1374
==========================================
- Hits 31941 31264 -677
+ Misses 22643 21984 -659
+ Partials 2580 2542 -38
|
…ita/evidence-hash
…ita/evidence-hash
…ita/evidence-hash
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good so far!
…ita/evidence-hash
…ita/evidence-hash
…ita/evidence-hash
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Be sure to add a changelog
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, pending changelog.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, +1 for the changelog
Description
Closes: #13444
This PR fixes the x/evidence api query which is not decoding the evidence hash properly because of its type ([]byte). We fix it with the following steps:
hash
of typestring
evidence_hash
field deprecatedAuthor Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change