feat(client/v2): add autocli run + simapp example #13867
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #13867 +/- ##
==========================================
+ Coverage 56.25% 56.44% +0.18%
==========================================
Files 667 651 -16
Lines 56576 56452 -124
==========================================
+ Hits 31829 31866 +37
+ Misses 22165 22015 -150
+ Partials 2582 2571 -11
|
|
[cosmos-sdk-client-v2] SonarCloud Quality Gate failed. |
| for moduleName := range customCmds { | ||
| allModuleNames[moduleName] = true | ||
| } |
Check failure
Code scanning / gosec
the value in the range statement should be _ unless copying a map: want: for key := range m
| for moduleName := range moduleOptions { | ||
| allModuleNames[moduleName] = true | ||
| } |
Check failure
Code scanning / gosec
the value in the range statement should be _ unless copying a map: want: for key := range m
|
tACK (the runtime command), because |
|
Once this is merged I'll submit another PR to bump |
|
[Cosmos SDK] Kudos, SonarCloud Quality Gate passed!
|
julienrbrt
removed
the
backport/v0.47.x
|
[Cosmos SDK - SimApp] Kudos, SonarCloud Quality Gate passed!
|
Co-authored-by: Julien Robert <julien@rbrt.fr>
Description
Closes: #13283
This adds autocli into
simdby graceful enhancement. Only commands which are missing a CLI command get an autocli command based on the options provided by a module'sHasAutoCLIConfigimplementation.In order to get this to work, I needed some queries that didn't have commands so I made runtime have an actual
AppModuleimplementation and generated commands for it with autocli.I suggest reviewers manually test this. I was attempting to start a simapp node but ran into issues. If there is a reviewer that would be able to test this against a simapp node that would be greatly appreciated.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change