Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aditya/docs core #1414

Closed
wants to merge 22 commits into from
Closed

Aditya/docs core #1414

wants to merge 22 commits into from

Conversation

AdityaSripal
Copy link
Member

  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG.md
  • Updated Gaia/Examples
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

ebuchman and others added 21 commits June 25, 2018 21:55
@ebuchman
example app1
2a48918
@ebuchman
docs: update readme structure with example apps
8a9acae
@ebuchman
docs/examples: templates for more examples
7cd96d1
@AdityaSripal
Added handler to app1
4ad5823
@AdityaSripal
Merge branch 'bucky/docs-core' of https://github.com/cosmos/cosmos-sdk …
30fb07b 
…into aditya/core-docs
@ebuchman
finish docs for app1
be492c0
@ebuchman
consolidate files into appX.md
ca9dfe2
@ebuchman
minor fixes
1178589
@ebuchman
fix comment
0d6dc6d
@ebuchman
more minor fixes
d654d8a
@ebuchman
more structure for app2 and app3 md
0e70582
@ebuchman
some reordering in app1 and app3
e6e59d5
@ebuchman
update readme
d24f5f2
@AdityaSripal
Finish app1-3, app4 done minus staking
43d1b91
@AdityaSripal
Merge branch 'bucky/docs-core' of https://github.com/cosmos/cosmos-sdk …
ba9cf34 
…into aditya/core-docs
@AdityaSripal
Remove unnecessary fields from simple account
7c0cd62
@AdityaSripal
Initialize coin metadata in app4 and fmt
4bdc0df
@AdityaSripal
Revert changes to app1 router
1c153d5
@AdityaSripal
Fix conflicts
9b226bb
@AdityaSripal
Improved apps with better handling/routing and simpler MsgIssue
e189754
@AdityaSripal
Added some documentation
dd41e58
@AdityaSripal AdityaSripal requested a review from ebuchman as a code owner June 27, 2018 21:52
@AdityaSripal
Copy link
Member Author

Simplified MsgIssue and improved handler routing
Also, cleaned up handlers for MsgIssue following example in handleMsgSend

@codecov
Copy link

codecov bot commented Jun 27, 2018 •
edited
Loading

Codecov Report

Merging #1414 into bucky/docs-core will not change coverage.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           bucky/docs-core    #1414   +/-   ##
================================================
  Coverage            62.16%   62.16%           
================================================
  Files                  103      103           
  Lines                 5838     5838           
================================================
  Hits                  3629     3629           
  Misses                1999     1999           
  Partials               210      210

@rigelrozanski rigelrozanski added wip T:Docs Changes and features related to documentation. labels Jun 27, 2018
@ebuchman ebuchman mentioned this pull request Jun 28, 2018
Merged
@ebuchman
Copy link
Member

Merged in #1434 thanks !

@ebuchman ebuchman closed this Jun 28, 2018
@AdityaSripal AdityaSripal deleted the aditya/docs-core branch July 10, 2018 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebuchman ebuchman Awaiting requested review from ebuchman

Assignees
No one assigned
Labels
T:Docs Changes and features related to documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AdityaSripal @ebuchman @rigelrozanski