WIP: Remove old tests from Makefile #143
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanfrey
force-pushed
the
feature/121-remove-old-tests
branch
from
7f734b8
to
9cdf004
Compare
|
I believe the tmsp_test is covered by unit tests but the main.go looks like it could be valuable to have. Not sure if its up-to-date, but would be nice to have a demo/script folks can run to spam their basecoin nodes ... |
|
Okay, I would be happy to add a new issue to add a benchmarking script, if that is okay with you? Or should I add an updated benchmark script as part of this PR? |
|
A new issue, or part of this PR, either sounds fine. Just link back to this so we don't lose that code . It's also good example code for talking to basecoin by websocket |
|
I'll punt this to later than and do it right... |
ethanfrey
changed the title
|
Never mind, will throw this away and do it right. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #121
Need @ebuchman to approve it... I think this is all outdated now with the new cli tests.