fix(store): Fix the TestFileStreamingService unit test. #14305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienrbrt
approved these changes
Dec 14, 2022
julienrbrt
added
backport/0.46.x
alexanderbez
approved these changes
Dec 14, 2022
| @@ -116,7 +116,8 @@ func TestFileStreamingService(t *testing.T) { | |||
| defer os.RemoveAll(testDir) | |||
|
|
|||
| testKeys := []types.StoreKey{mockStoreKey1, mockStoreKey2} | |||
| testStreamingService, err := NewStreamingService(testDir, testPrefix, testKeys, testMarshaller, log.NewNopLogger(), true, false, false) | |||
| var err error | |||
| testStreamingService, err = NewStreamingService(testDir, testPrefix, testKeys, testMarshaller, log.NewNopLogger(), true, false, false) | |||
| require.Nil(t, err) | |||
There was a problem hiding this comment.
Suggested change
| require.Nil(t, err) | |
| require.NoError(t, err) |
There was a problem hiding this comment.
I agree that it should be NoError, but there are a whole lot of other things about this test that should also be fixed, and I didn't want to get lost in all of it. E.g. require.Nil is used against errors in many places.
This reverts commit 1f88277.
…osmos-sdk into dwedul/14302-fix-streaming-test
mergify bot
pushed a commit
that referenced
this pull request
Dec 14, 2022
(cherry picked from commit aba4e6e)
mergify bot
pushed a commit
that referenced
this pull request
Dec 14, 2022
(cherry picked from commit aba4e6e) # Conflicts: # store/streaming/file/service_test.go
julienrbrt
added a commit
that referenced
this pull request
Dec 14, 2022
) (#14309) Co-authored-by: Daniel Wedul <github@wedul.com> Co-authored-by: Julien Robert <julien@rbrt.fr>
ryanchristo
pushed a commit
to regen-network/cosmos-sdk
that referenced
this pull request
Dec 15, 2022
…mos#14305) (cosmos#14309) Co-authored-by: Daniel Wedul <github@wedul.com> Co-authored-by: Julien Robert <julien@rbrt.fr>
19 tasks
julienrbrt
pushed a commit
that referenced
this pull request
Dec 15, 2022
) (#14308) Co-authored-by: Daniel Wedul <github@wedul.com>
JeancarloBarrios
pushed a commit
to agoric-labs/cosmos-sdk
that referenced
this pull request
Sep 28, 2024
…mos#14305) (cosmos#14309) Co-authored-by: Daniel Wedul <github@wedul.com> Co-authored-by: Julien Robert <julien@rbrt.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #14302
Fix the
TestFileStreamingServiceunit test.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
addedN/A!to the type prefix if API or client breaking changefollowed the guidelines for building modulesN/Aincluded the necessary unit and integration testsN/ACHANGELOG.mdincluded comments for documenting Go codeN/Aupdated the relevant documentation or specificationN/AReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change