refactor: add module name to message server #14352
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tac0turtle
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+166
to
+172
| for k := range msr.names { | ||
| if strings.Contains(msgUrl, k) { | ||
| if !strings.Contains(k, ":") { // avoid setting moduleurl to storekeys like transient:params | ||
| msr.moduleNames[msgUrl] = k // put the module name on the message url | ||
| } | ||
| } | ||
| } |
Check failure
Code scanning / gosec
the value in the range statement should be _ unless copying a map: want: for key := range m
Comment on lines
+166
to
+172
| for k := range msr.names { | ||
| if strings.Contains(msgUrl, k) { | ||
| if !strings.Contains(k, ":") { // avoid setting moduleurl to storekeys like transient:params | ||
| msr.moduleNames[msgUrl] = k // put the module name on the message url | ||
| } | ||
| } | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map
|
I think we may need something similar for queries in the future to fill remove the need to register errors with module names if that path is chosen. |
|
Closing in favor of #14356 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
this pr uses store keys as module message url identifiers instead of a string search.
this can also be used to wrap errors on return of message result removing the need to register errors
attempt to close: #14295
this is a bit hacky but safer then strings.Split(".") imo
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change