Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: revert API breaking change on Slash #14363

Merged
merged 7 commits into from
Dec 20, 2022
Merged

refactor: revert API breaking change on Slash #14363

merged 7 commits into from
Dec 20, 2022

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Dec 19, 2022 •
edited
Loading

Description

Remembered a conversation about reverting the breaking change when auditing x/slashing.
ref: #14255, #14158

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt added the backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release label Dec 19, 2022
@julienrbrt julienrbrt marked this pull request as ready for review December 20, 2022 09:20
@julienrbrt julienrbrt requested a review from a team as a code owner December 20, 2022 09:20
mpoke
mpoke approved these changes Dec 20, 2022
View reviewed changes
Copy link

@mpoke mpoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Dec 20, 2022

[Cosmos SDK] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
No Duplication information No Duplication information

tac0turtle
tac0turtle approved these changes Dec 20, 2022
View reviewed changes
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@julienrbrt julienrbrt merged commit 419de8d into main Dec 20, 2022
@julienrbrt julienrbrt deleted the julien/staking branch December 20, 2022 11:12
@mergify mergify bot mentioned this pull request Dec 20, 2022
Merged
mergify bot pushed a commit that referenced this pull request Dec 20, 2022
@julienrbrt @mergify
refactor: revert API breaking change on Slash (#14363)
d22d3a4 
(cherry picked from commit 419de8d)

# Conflicts:
#	CHANGELOG.md
alexanderbez pushed a commit that referenced this pull request Dec 20, 2022
@mergify @julienrbrt
refactor: revert API breaking change on Slash (backport #14363) (#14365)
7e7e7f7 
Co-authored-by: Julien Robert <julien@rbrt.fr>
@AaronKutch AaronKutch mentioned this pull request Apr 7, 2023
Merged
@0xstepit 0xstepit mentioned this pull request Jul 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tac0turtle tac0turtle tac0turtle approved these changes

@mpoke mpoke mpoke approved these changes

@aaronc aaronc Awaiting requested review from aaronc aaronc is a code owner automatically assigned from cosmos/sdk-core-dev

@facundomedica facundomedica Awaiting requested review from facundomedica facundomedica is a code owner automatically assigned from cosmos/sdk-core-dev

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

Assignees
No one assigned
Labels
backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release C:x/evidence C:x/slashing C:x/staking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@julienrbrt @mpoke @tac0turtle