Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(collections): add sequence #14364

Merged
merged 6 commits into from
Dec 21, 2022
Merged

feat(collections): add sequence #14364

merged 6 commits into from
Dec 21, 2022

Conversation

testinginprod
Copy link
Contributor

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)


// Sequence builds on top of an Item, and represents
// an ever-increasing number.
type Sequence Item[uint64]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naive q: what is the usecase for this type

Copy link
Contributor Author

@testinginprod testinginprod Dec 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a common type, EG: auth account number, everything that uses an ever increasing unique ID.

collections/sequence.go Outdated Show resolved Hide resolved
collections/sequence.go Outdated Show resolved Hide resolved
testinginprod and others added 3 commits December 20, 2022 18:39
@testinginprod testinginprod enabled auto-merge (squash) December 21, 2022 08:16
@sonarcloud
Copy link

sonarcloud bot commented Dec 21, 2022

[Cosmos SDK - Collections] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

81.8% 81.8% Coverage
0.0% 0.0% Duplication

@testinginprod testinginprod merged commit 1d16adc into main Dec 21, 2022
@testinginprod testinginprod deleted the tip/collections-sequence branch December 21, 2022 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants