refactor: make cachekv store thread-safe again #14378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes: cosmos#14376 Solution: - copy isolated sortedCache when starting iterating - cleanup deletion logic
store/cachekv/internal/btree.go
Outdated
| if (start != nil && len(start) == 0) || (end != nil && len(end) == 0) { | ||
| return nil, errKeyEmpty | ||
| panic(errKeyEmpty) |
There was a problem hiding this comment.
Why are we panic over error? Ideally, the caller can handle the error.
There was a problem hiding this comment.
I'm just trying to make it similar to KVStore interface, it's usage in the store is side with the parent store, so i try to make the interface similar to the parent store.
There was a problem hiding this comment.
Yes, but I'd argue those interfaces are bad.
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
alexanderbez
approved these changes
Dec 21, 2022
mmsqe
pushed a commit
to mmsqe/cosmos-sdk
that referenced
this pull request
Dec 27, 2022
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
mmsqe
pushed a commit
to mmsqe/cosmos-sdk
that referenced
this pull request
Dec 28, 2022
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
yihuang
added a commit
to yihuang/cosmos-sdk
that referenced
this pull request
Jan 10, 2023
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
19 tasks
|
@Mergifyio backport release/v0.47.x |
|
backporting as per #14798 (comment) |
mergify bot
pushed a commit
that referenced
this pull request
Jan 27, 2023
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> (cherry picked from commit f1ee974) # Conflicts: # CHANGELOG.md # store/cachekv/internal/btree.go # store/cachekv/internal/memiterator.go
✅ Backports have been created
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #14376
Solution:
go test -run=^$ -bench=. -benchmem ./store/cachekv/... -count=10Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change