Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gov): support v1.Proposal in v1beta1.Proposal.Content (backport #14347) #14400

Merged
merged 2 commits into from
Dec 23, 2022

Conversation

robert-zaremba
Copy link
Collaborator

Description

backport #14347


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@robert-zaremba
Copy link
Collaborator Author

removed for loop here as well.

@robert-zaremba robert-zaremba changed the title Robert/v1 proposal backport feat(gov): support v1.Proposal in v1beta1.Proposal.Content (backport #14347) Dec 22, 2022
@julienrbrt
Copy link
Member

removed for loop here as well.

Cool, can you do a quick pr for cleaning up main too?

@robert-zaremba
Copy link
Collaborator Author

Cool, can you do a quick pr for cleaning up main too?

Done,

thanks for swift review @julienrbrt

@julienrbrt julienrbrt merged commit e641907 into release/v0.46.x Dec 23, 2022
@julienrbrt julienrbrt deleted the robert/v1-proposal-backport branch December 23, 2022 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/gov
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants