Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: parallelize tests where possible #14412

Closed
wants to merge 18 commits into from

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Dec 24, 2022

  • parallel tests
  • paralleltest

Description

Closes: #XXXX

This PR extends the linting of tests, and adds parallelization by
adding paralleltest to .golangci.yml


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@faddat faddat requested a review from a team as a code owner December 24, 2022 11:34
@faddat faddat marked this pull request as draft December 24, 2022 11:35
@julienrbrt
Copy link
Member

Wow, thanks for that. You can skip e2e tests btw as we are going to completely refactor them.

Tests using testify suite can as well be skipped (stretchr/testify#187)

@tac0turtle
Copy link
Member

tac0turtle commented Dec 24, 2022

Lets pice meal this across a few prs, I see the commits and worried about unforeseen issues

Some tests are already failing with data races, let's revert some of these and go package b package. it's easier to reason about the changes and easier to identify when something is causing issues. @faddat are you okay with that?

@faddat
Copy link
Contributor Author

faddat commented Dec 24, 2022

totally okay with that -- I was thinking the same thing approximately.

@faddat
Copy link
Contributor Author

faddat commented Dec 24, 2022

It started to look like this:

https://www.youtube.com/watch?v=tZqBrMqZLR4

@faddat
Copy link
Contributor Author

faddat commented Dec 25, 2022

Going to close this, and maybe reapproach module by module or such. Definitely began to cause unforeseen circumstances.

@faddat faddat closed this Dec 25, 2022
@tac0turtle tac0turtle deleted the parallel-test branch December 25, 2022 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants