-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: parallelize tests where possible #14412
Conversation
Wow, thanks for that. You can skip e2e tests btw as we are going to completely refactor them. Tests using testify suite can as well be skipped (stretchr/testify#187) |
Lets pice meal this across a few prs, I see the commits and worried about unforeseen issues Some tests are already failing with data races, let's revert some of these and go package b package. it's easier to reason about the changes and easier to identify when something is causing issues. @faddat are you okay with that? |
totally okay with that -- I was thinking the same thing approximately. |
It started to look like this: |
Going to close this, and maybe reapproach module by module or such. Definitely began to cause unforeseen circumstances. |
Description
Closes: #XXXX
This PR extends the linting of tests, and adds parallelization by
adding paralleltest to .golangci.yml
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change