Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: longer golang-ci timeout #14432

Merged
merged 1 commit into from
Dec 27, 2022

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Dec 27, 2022

Description

This PR increases the golangci-lint timeout to 10 minutes, and tells it to run concurrently.

It is not worthy of a changelog entry.

reason: I noticed the linter had timed out in


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

* Add "concurrency = 4"
@faddat faddat requested a review from a team as a code owner December 27, 2022 13:39
@tac0turtle
Copy link
Member

wow, this is odd, seems like ci is even on holiday

Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems harmless for now. Ideally the never gets hit.

@tac0turtle tac0turtle merged commit c1580c9 into cosmos:main Dec 27, 2022
@tac0turtle tac0turtle deleted the faddat/minor-golang-ci branch December 27, 2022 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants