-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix --log_format
flag not working
#14441
Conversation
dcbd070
to
a1a27c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
[Cosmos SDK] Kudos, SonarCloud Quality Gate passed! |
(cherry picked from commit 82bd888) # Conflicts: # CHANGELOG.md
Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: Marko <marbar3778@yahoo.com>
Hi Julien! Thanks for adding the fix. Were you able to toggle between json and plain log format after this fix? Asking because when I tested things on our chain, I had to change the default value to json here. Only after this change, I was able to use the input flag to toggle between plain and json. |
Hi, Yes I had no problem getting json formatted log with simapp using the flag. |
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change