Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: return anteEvents when postHandler fail #14448

Merged
merged 4 commits into from
Dec 31, 2022
Merged

fix: return anteEvents when postHandler fail #14448

merged 4 commits into from
Dec 31, 2022

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Dec 30, 2022 •
edited
Loading

Description

Just found this when reading the code and think it maybe not expected.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@yihuang yihuang requested a review from a team as a code owner December 30, 2022 03:23
tac0turtle
tac0turtle reviewed Dec 30, 2022
View reviewed changes
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@sonarcloud
Copy link

sonarcloud bot commented Dec 30, 2022

[Cosmos SDK] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@julienrbrt
Copy link
Member

Should this be backported to 0.46 and 0.47?

@yihuang
Copy link
Collaborator Author

yihuang commented Dec 31, 2022

Should this be backported to 0.46 and 0.47?

I think so

@julienrbrt julienrbrt added backport/0.46.x PR scheduled for inclusion in the v0.46's next stable release backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release labels Dec 31, 2022
julienrbrt
julienrbrt approved these changes Dec 31, 2022
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@julienrbrt julienrbrt enabled auto-merge (squash) December 31, 2022 11:27
@julienrbrt julienrbrt merged commit 9a8b65b into main Dec 31, 2022
@julienrbrt julienrbrt deleted the yihuang-patch-1 branch December 31, 2022 11:45
@mergify mergify bot mentioned this pull request Dec 31, 2022
Merged
mergify bot pushed a commit that referenced this pull request Dec 31, 2022
@yihuang @mergify
fix: return anteEvents when postHandler fail (#14448)
b357358 
(cherry picked from commit 9a8b65b)

# Conflicts:
#	CHANGELOG.md
@mergify mergify bot mentioned this pull request Dec 31, 2022
Merged
mergify bot pushed a commit that referenced this pull request Dec 31, 2022
@yihuang @mergify
fix: return anteEvents when postHandler fail (#14448)
4fad790 
(cherry picked from commit 9a8b65b)

# Conflicts:
#	CHANGELOG.md
julienrbrt pushed a commit that referenced this pull request Dec 31, 2022
@mergify
fix: return anteEvents when postHandler fail (backport #14448) (#14458)
8ed17b9
julienrbrt pushed a commit that referenced this pull request Jan 1, 2023
@mergify @yihuang
fix: return anteEvents when postHandler fail (backport #14448) (#14459)
e7dd5e0 
Co-authored-by: yihuang <huang@crypto.com>
@clevinson clevinson mentioned this pull request Jan 4, 2023
Merged
19 tasks
jiujiteiro pushed a commit to realiotech/cosmos-sdk that referenced this pull request Mar 7, 2023
@mergify @yihuang @jiujiteiro
fix: return anteEvents when postHandler fail (backport cosmos#14448) (c…
8b6a667 
…osmos#14459)

Co-authored-by: yihuang <huang@crypto.com>
@LampardNguyen234 LampardNguyen234 mentioned this pull request Aug 15, 2023
Merged
@0xstepit 0xstepit mentioned this pull request Jul 1, 2024
Merged
JeancarloBarrios pushed a commit to agoric-labs/cosmos-sdk that referenced this pull request Sep 28, 2024
@mergify @yihuang @JeancarloBarrios
fix: return anteEvents when postHandler fail (backport cosmos#14448) (c…
bfd3e58 
…osmos#14459)

Co-authored-by: yihuang <huang@crypto.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@tac0turtle tac0turtle tac0turtle approved these changes

@alexanderbez alexanderbez alexanderbez approved these changes

@facundomedica facundomedica Awaiting requested review from facundomedica facundomedica is a code owner

Assignees
No one assigned
Labels
backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release backport/0.46.x PR scheduled for inclusion in the v0.46's next stable release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yihuang @julienrbrt @alexanderbez @tac0turtle