-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Clean up {accept,implement}_interface
(backport #14476)
#14478
Merged
tac0turtle
merged 10 commits into
release/v0.47.x
from
mergify/bp/release/v0.47.x/pr-14476
Jan 4, 2023
Merged
chore: Clean up {accept,implement}_interface
(backport #14476)
#14478
tac0turtle
merged 10 commits into
release/v0.47.x
from
mergify/bp/release/v0.47.x/pr-14476
Jan 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit b244ffb) # Conflicts: # CHANGELOG.md # api/cosmos/auth/v1beta1/auth.pulsar.go # api/cosmos/bank/v1beta1/bank.pulsar.go # api/cosmos/gov/v1beta1/gov.pulsar.go # api/cosmos/gov/v1beta1/tx.pulsar.go # proto/cosmos/auth/v1beta1/auth.proto # proto/cosmos/evidence/v1beta1/tx.proto # proto/cosmos/gov/v1beta1/gov.proto # proto/cosmos/gov/v1beta1/tx.proto # x/auth/types/auth.pb.go # x/bank/types/bank.pb.go # x/gov/types/v1beta1/gov.pb.go # x/gov/types/v1beta1/tx.pb.go
tac0turtle
reviewed
Jan 4, 2023
tac0turtle
reviewed
Jan 4, 2023
tac0turtle
reviewed
Jan 4, 2023
tac0turtle
reviewed
Jan 4, 2023
tac0turtle
reviewed
Jan 4, 2023
amaury1093
approved these changes
Jan 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tac0turtle!
@@ -74,6 +74,31 @@ This allows you to remove the replace directive `replace github.com/gogo/protobu | |||
|
|||
Please use the `ghcr.io/cosmos/proto-builder` image (version >= `0.11.0`) for generating protobuf files. | |||
|
|||
#### `{accepts,implements}_interface` proto annotations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changelog entry got removed
julienrbrt
reviewed
Jan 4, 2023
julienrbrt
reviewed
Jan 4, 2023
tac0turtle
approved these changes
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #14476 done by Mergify.
Cherry-pick of b244ffb has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com