refactor: add title and summary to groups proposal (backport #14465) #14482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
(cherry picked from commit 7b12333)
julienrbrt
approved these changes
Jan 4, 2023
julienrbrt
force-pushed
the
mergify/bp/release/v0.47.x/pr-14465
branch
from
152b8f7 to
10c256c
Compare
|
[Cosmos SDK] Kudos, SonarCloud Quality Gate passed!
|
amaury1093
approved these changes
Jan 5, 2023
| // title is the title of the proposal. | ||
| // | ||
| // Since: cosmos-sdk 0.47 | ||
| string title = 6; |
There was a problem hiding this comment.
One thing I forgot to notice in the original PR: we need to bump gov and group's ConsensusVersion
There was a problem hiding this comment.
good point!, group already been bumped with the group policy account change, but we do need gov indeed.
There was a problem hiding this comment.
Checking now, gov has been bumped with params change, so we are good!
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #14465 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com