Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: keyring-backend flag usage #14509

Merged
merged 5 commits into from
Jan 5, 2023
Merged

fix: keyring-backend flag usage #14509

merged 5 commits into from
Jan 5, 2023

Conversation

robert-zaremba
Copy link
Collaborator

Description

./build/simd keys --help shows wrong --keyring-backend usage doc:

--keyring-backend string   Select keyring's backend (os|file|test) (default "os")

It's missing pass and memory.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@robert-zaremba robert-zaremba added T:Bug backport/0.46.x PR scheduled for inclusion in the v0.46's next stable release backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release labels Jan 5, 2023
@robert-zaremba robert-zaremba requested a review from a team as a code owner January 5, 2023 17:31
@github-actions github-actions bot added C:CLI C:Keys Keybase, KMS and HSMs labels Jan 5, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jan 5, 2023

[Cosmos SDK] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, can you gofumpt?

@julienrbrt julienrbrt enabled auto-merge (squash) January 5, 2023 20:33
@julienrbrt julienrbrt merged commit 3e2dde5 into main Jan 5, 2023
@julienrbrt julienrbrt deleted the robert/fix-keyring-flags branch January 5, 2023 20:52
mergify bot pushed a commit that referenced this pull request Jan 5, 2023
(cherry picked from commit 3e2dde5)

# Conflicts:
#	CHANGELOG.md
mergify bot pushed a commit that referenced this pull request Jan 5, 2023
(cherry picked from commit 3e2dde5)

# Conflicts:
#	CHANGELOG.md
#	client/flags/flags.go
#	docs/docs/run-node/00-keyring.md
julienrbrt added a commit that referenced this pull request Jan 5, 2023
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Julien Robert <julien@rbrt.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release backport/0.46.x PR scheduled for inclusion in the v0.46's next stable release C:CLI C:Keys Keybase, KMS and HSMs T:Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants