-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use CacheContext() in AssertInvariants() #14588
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I provide supplementary comments.
x/crisis/keeper/keeper.go
Outdated
@@ -84,6 +84,8 @@ func (k *Keeper) AssertInvariants(ctx sdk.Context) { | |||
n := len(invarRoutes) | |||
for i, ir := range invarRoutes { | |||
logger.Info("asserting crisis invariants", "inv", fmt.Sprint(i+1, "/", n), "name", ir.FullRoute()) | |||
|
|||
ctx, _ := ctx.CacheContext() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add CacheContext()
inside the loop, otherwise, an invariant may affect the other's precondition.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems reasonable to me
lgtm, add Bez's nits and we are good to merge |
Rename the variable for clarity. Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Description
Closes: #14587
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change