Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(baseapp): handle cases for PostHandler in runTx #14593

Closed
wants to merge 20 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update baseapp/baseapp.go
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
  • Loading branch information
Vvaradinov and fedekunze authored Jan 13, 2023
commit 3d1a227c0a7a3ebb39099bb5fa3e31f3ab3c2544
2 changes: 1 addition & 1 deletion baseapp/baseapp.go
Original file line number Diff line number Diff line change
@@ -725,7 +725,7 @@ func (app *BaseApp) runTx(mode runTxMode, txBytes []byte) (gInfo sdk.GasInfo, re

Vvaradinov marked this conversation as resolved.
Show resolved Hide resolved
// Case 1: the msg errors and the post handler is not set.
if err != nil && app.postHandler == nil {
return gInfo, nil, events, priority, err
return gInfo, nil, anteEvents, priority, err
fedekunze marked this conversation as resolved.
Show resolved Hide resolved
fedekunze marked this conversation as resolved.
Show resolved Hide resolved
}

// Case 2: tx errors and the post handler is set. Run PostHandler and revert state from runMsgs