-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): add event service #14686
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but how does this facilitate listening?
I removed the listener API from this PR so that that's a separate discussion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, pending some godoc clarification
Description
Closes: #14685
This adds an event servicec type to the core module API which supports both ADR 032 typed events and legacy ABCI events.
It specifies which event methods should be assumed to be part of blockchain consensus and which ones should be assumed to be non-deterministic. Currently we don't support events as part of consensus, but this API attempts to lay the groundwork for adding them in the future and for also allowing other parts of the state machine to listen to such events.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change