Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add event service #14686

Merged
merged 9 commits into from
Jan 23, 2023
Merged

feat(core): add event service #14686

merged 9 commits into from
Jan 23, 2023

Conversation

aaronc
Copy link
Member

@aaronc aaronc commented Jan 18, 2023

Description

Closes: #14685

This adds an event servicec type to the core module API which supports both ADR 032 typed events and legacy ABCI events.

It specifies which event methods should be assumed to be part of blockchain consensus and which ones should be assumed to be non-deterministic. Currently we don't support events as part of consensus, but this API attempts to lay the groundwork for adding them in the future and for also allowing other parts of the state machine to listen to such events.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@aaronc aaronc marked this pull request as ready for review January 18, 2023 17:59
@aaronc aaronc requested a review from a team as a code owner January 18, 2023 17:59
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but how does this facilitate listening?

core/event/manager.go Outdated Show resolved Hide resolved
core/event/manager.go Outdated Show resolved Hide resolved
@aaronc
Copy link
Member Author

aaronc commented Jan 18, 2023

LGTM, but how does this facilitate listening?

I removed the listener API from this PR so that that's a separate discussion

core/event/manager.go Outdated Show resolved Hide resolved
core/event/manager.go Outdated Show resolved Hide resolved
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending some godoc clarification

@aaronc aaronc changed the title feat(core): add event manager feat(core): add event service Jan 23, 2023
@aaronc aaronc enabled auto-merge (squash) January 23, 2023 17:40
@aaronc aaronc merged commit 9b5ac6a into main Jan 23, 2023
@aaronc aaronc deleted the aaronc/core-api-events branch January 23, 2023 17:54
@coderabbitai coderabbitai bot mentioned this pull request May 3, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specify core API events
5 participants