Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve rpc message when app is at height 0 #14692

Merged
merged 4 commits into from
Jan 19, 2023
Merged

fix: improve rpc message when app is at height 0 #14692

merged 4 commits into from
Jan 19, 2023

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Jan 19, 2023 •
edited
Loading

Description

Closes: #14620

Chosen for the simplest implementation: Improving the error message so and let clients handle their retry logic themselves.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt requested a review from a team as a code owner January 19, 2023 13:02
likhita-809
likhita-809 approved these changes Jan 19, 2023
View reviewed changes
Copy link
Contributor

@likhita-809 likhita-809 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@julienrbrt julienrbrt enabled auto-merge (squash) January 19, 2023 19:04
@julienrbrt julienrbrt merged commit d67e92a into main Jan 19, 2023
@julienrbrt julienrbrt deleted the julien/rpc-height-check branch January 19, 2023 19:15
@julienrbrt
Copy link
Member Author

@Mergifyio backport release/v0.47.x

mergify bot pushed a commit that referenced this pull request Jan 19, 2023
@julienrbrt @mergify
fix: improve rpc message when app is at height 0 (#14692)
82a3651 
(cherry picked from commit d67e92a)

# Conflicts:
#	CHANGELOG.md
@mergify mergify bot mentioned this pull request Jan 19, 2023
Merged
@mergify
Copy link
Contributor

mergify bot commented Jan 19, 2023

backport release/v0.47.x

✅ Backports have been created

julienrbrt added a commit that referenced this pull request Jan 19, 2023
@mergify @julienrbrt
fix: improve rpc message when app is at height 0 (backport #14692) (#…
30bd414 
…14703)

Co-authored-by: Julien Robert <julien@rbrt.fr>
@0xstepit 0xstepit mentioned this pull request Jul 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@likhita-809 likhita-809 likhita-809 approved these changes

@alexanderbez alexanderbez alexanderbez approved these changes

@kocubinski kocubinski Awaiting requested review from kocubinski kocubinski is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RPC requests during node startup trigger error
3 participants
@julienrbrt @alexanderbez @likhita-809