-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: do not flatten events attributes by event types (backport #14691) #14702
fix: do not flatten events attributes by event types (backport #14691) #14702
Conversation
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> (cherry picked from commit d5d39c0) # Conflicts: # CHANGELOG.md
We should notify relayers of this. |
merging for now, pinged the ibc team. cc @jackzampolin @adizere for visibility |
It's difficult for me to say if this will break relayers (in addition to the even encoding breaking changes Tendermint v0.37.0). Should we expect it to be a breaking change and do tests? Thanks! |
@julienrbrt want to cut a new rc and ill update ibc to see if things break? |
Sure thing, but isn't it better to have an RC2 with #14713 and the IAVL changes? |
This is an automatic backport of pull request #14691 done by Mergify.
Cherry-pick of d5d39c0 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com