Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make x/evidence a standalone module #14724

Merged
merged 16 commits into from
Jan 24, 2023

Conversation

likhita-809
Copy link
Contributor

Description

Closes: #14557


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@likhita-809 likhita-809 marked this pull request as ready for review January 23, 2023 05:38
@likhita-809 likhita-809 requested a review from a team as a code owner January 23, 2023 05:38
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Other nits: can you add a module UPGRADING.md section mentioning the extraction of evidence, nft in their go.mod (and their renaming)? As well as a CHANGELOG, mentioning the extraction and renaming, in the main changelog and evidence/CHANGELOG? Additionally, the import grouping seems sometimes weird.

simapp/app.go Outdated Show resolved Hide resolved
simapp/app_v2.go Outdated Show resolved Hide resolved
x/evidence/sonar-project.properties Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jan 23, 2023

[Cosmos SDK - x/evidence] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

CHANGELOG.md Outdated Show resolved Hide resolved
x/evidence/CHANGELOG.md Outdated Show resolved Hide resolved
UPGRADING.md Outdated Show resolved Hide resolved
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@likhita-809, could you revert the permission of protocgen.sh to 755?

@kocubinski kocubinski self-assigned this Jan 23, 2023
@julienrbrt julienrbrt merged commit 09e3e55 into main Jan 24, 2023
@julienrbrt julienrbrt deleted the likhita/evidence-standalone branch January 24, 2023 09:01
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: x/evidence as a standalone go module
3 participants