Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client/lcd: fix tests #1491

Merged
merged 4 commits into from
Jun 30, 2018
Merged

client/lcd: fix tests #1491

merged 4 commits into from
Jun 30, 2018

Conversation

ebuchman
Copy link
Member

@ebuchman ebuchman commented Jun 30, 2018 •
edited
Loading 

ok      github.com/cosmos/cosmos-sdk/client/lcd 10.824s

Much better.

The WaitFor funcs were totally broken. Also made the block commit time 10x faster

@ValarDragon
Copy link
Contributor

Oh cool! This also explains why lowering the bcrypt parameter didn't change the time as much as I thought it would, I was profiling cpu time.

@ebuchman
Copy link
Member Author

I updated to latest develop but now locally and on Circle I'm getting:

--- FAIL: TestUnrevoke (1.42s)
	assertions.go:247: 
                          
	Error Trace:	lcd_test.go:699
		
	            	
			lcd_test.go:531
		
	Error:      	Not equal: 
		
	            	expected: 200
		
	            	actual  : 500
		
	Test:       	TestUnrevoke
		
	Messages:   	couldn't decode signing info. Error: UnmarshalBinary cannot decode empty bytes

@ebuchman
Copy link
Member Author

@rigelrozanski @cwgoes above issue is fixed by https://github.com/cosmos/cosmos-sdk/pull/1491/files#diff-a76d5d06816361792481ba6a8fdfc428R531

Was masked before by the startup sequence waiting longer than it should. Do we need to initialize the slashing store in InitChain or something ? And why would this only work if we wait for Block3 rather than Block2?

@codecov
Copy link

codecov bot commented Jun 30, 2018

Codecov Report

Merging #1491 into develop will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           develop    #1491   +/-   ##
========================================
  Coverage    64.48%   64.48%           
========================================
  Files          118      118           
  Lines         6493     6493           
========================================
  Hits          4187     4187           
  Misses        2050     2050           
  Partials       256      256

@cwgoes
Copy link
Contributor

cwgoes commented Jun 30, 2018

Was masked before by the startup sequence waiting longer than it should. Do we need to initialize the slashing store in InitChain or something ? And why would this only work if we wait for Block3 rather than Block2?

Probably caused by a different initial validator set and initial stake distribution; hopefully will be fixed by #1373 (otherwise we can debug further).

cwgoes
cwgoes approved these changes Jun 30, 2018
View reviewed changes
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK

@cwgoes cwgoes merged commit feb3acd into develop Jun 30, 2018
@cwgoes cwgoes deleted the bucky/lcd-tests branch June 30, 2018 23:32
adrianbrink pushed a commit that referenced this pull request Jul 2, 2018
@ebuchman
Merge PR #1491: client/lcd: fix tests
1e9b3f3 
* client/lcd: fix tests
* circle: drop test_unit. store artifacts in test_cover
* hack fix in TestUnrevoke
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwgoes cwgoes cwgoes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ebuchman @ValarDragon @cwgoes