Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: rename functions, API to CometBFT #14910

Closed
wants to merge 14 commits into from

Conversation

julienrbrt
Copy link
Member

Description

Blocked on #14897
ref: #14870, #14897

This is a PR that rename all commands to API to cometbft and mention of Tendermint Core in the code and docs.
Aliases will be set in place to stay minimally breaking.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt added the S:blocked Status: Blocked label Feb 4, 2023
@julienrbrt julienrbrt changed the title refactor!: migrate Cosmos SDK to CometBFT refactor!: rename functions, API and docs to CometBFT Feb 4, 2023
Base automatically changed from julien/migrate-cometbft to main February 5, 2023 13:51
@julienrbrt julienrbrt removed the S:blocked Status: Blocked label Feb 5, 2023
@github-actions github-actions bot added C:Rosetta Issues and PR related to Rosetta C:Store Type: Build labels Feb 5, 2023
@github-actions github-actions bot added C:Confix Issues and PR related to Confix C:Cosmovisor Issues and PR related to Cosmovisor C:Hubl Tool: Hubl C:x/circuit labels Feb 5, 2023
@julienrbrt julienrbrt changed the title refactor!: rename functions, API and docs to CometBFT refactor!: rename functions, API to CometBFT Feb 5, 2023
@julienrbrt julienrbrt changed the base branch from main to julien/migrate-cometbft-2 February 5, 2023 17:39
@julienrbrt
Copy link
Member Author

Closing this for now, I will keep migrating main in a non-breaking way in #14914 (renaming of imports and stuff).
I want to discuss in our standup up to which point we want to be breaking.

@julienrbrt julienrbrt closed this Feb 5, 2023
@julienrbrt julienrbrt deleted the julien/rename-to-cometbft branch February 5, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant