Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: x/group pagination from CLI #14923

Merged
merged 8 commits into from
Feb 6, 2023
Merged

fix: x/group pagination from CLI #14923

merged 8 commits into from
Feb 6, 2023

Conversation

atheeshp
Copy link
Contributor

@atheeshp atheeshp commented Feb 6, 2023

Description

Most of the query commands in x/groups module missed pagination registration, but they are being used in code. There will be an error thrown if we use pagination from CLI in the current scenario.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@atheeshp atheeshp marked this pull request as ready for review February 6, 2023 12:18
@atheeshp atheeshp requested a review from a team as a code owner February 6, 2023 12:18
likhita-809
likhita-809 approved these changes Feb 6, 2023
View reviewed changes
Copy link
Contributor

@likhita-809 likhita-809 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@julienrbrt julienrbrt added the backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release label Feb 6, 2023
julienrbrt
julienrbrt approved these changes Feb 6, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@atheeshp atheeshp enabled auto-merge (squash) February 6, 2023 13:32
@atheeshp atheeshp merged commit fd7bbd7 into main Feb 6, 2023
@atheeshp atheeshp deleted the ap/fix-groups-pagination branch February 6, 2023 13:56
@mergify mergify bot mentioned this pull request Feb 6, 2023
Merged
mergify bot pushed a commit that referenced this pull request Feb 6, 2023
@atheeshp @mergify
fix: x/group pagination from CLI (#14923)
997c082 
(cherry picked from commit fd7bbd7)

# Conflicts:
#	x/group/client/cli/query.go
@atheeshp
Copy link
Contributor Author

atheeshp commented Feb 6, 2023

Missed changelog updation under bug fix.

@julienrbrt
Copy link
Member

Missed changelog updation under bug fix.

It can be added in the backported PR then: #14926.
The changelog from main would have been deleted anyway at v0.47 release.

julienrbrt added a commit that referenced this pull request Feb 6, 2023
@mergify @atheeshp @julienrbrt
fix: x/group pagination from CLI (backport #14923) (#14926)
6ed270d 
Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
Co-authored-by: atheesh <atheesh@vitwit.com>
samricotta pushed a commit that referenced this pull request Feb 7, 2023
@atheeshp @samricotta
fix: x/group pagination from CLI (#14923)
29d304f
@faddat faddat mentioned this pull request Mar 28, 2023
Closed
19 tasks
tsenart pushed a commit to meka-dev/cosmos-sdk that referenced this pull request Apr 12, 2023
@atheeshp @tsenart
fix: x/group pagination from CLI (cosmos#14923)
2ffbd6e
@0xstepit 0xstepit mentioned this pull request Jul 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@likhita-809 likhita-809 likhita-809 approved these changes

@julienrbrt julienrbrt julienrbrt approved these changes

@kocubinski kocubinski Awaiting requested review from kocubinski kocubinski is a code owner

@tac0turtle tac0turtle Awaiting requested review from tac0turtle

Assignees
No one assigned
Labels
backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release C:CLI C:x/group
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atheeshp @julienrbrt @likhita-809