Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Clean-ups after Textual Title/Content PR #14973

Merged
merged 1 commit into from
Feb 9, 2023
Merged

chore: Clean-ups after Textual Title/Content PR #14973

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/architecture/adr-050-sign-mode-textual.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,8 +129,8 @@ The SignDoc for `SIGN_MODE_TEXTUAL` is formed from a data structure like:

```go
type Screen struct {
Title string // possibly size limited to, e.g. 64 characters
Content string // possibly size limited to, e.g. 255 characters
Title string // possibly size limited to, advised to 64 characters
Content string // possibly size limited to, advised to 255 characters
Indent uint8 // size limited to something small like 16 or 32
Expert bool
}
Expand Down
2 changes: 1 addition & 1 deletion x/tx/textual/encode.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ var (
// ? indent_key: uint,
// ? expert_key: bool,
// }
// text_key = 1
// title_key = 1
// content_key = 2
// indent_key = 3
// expert_key = 4
Expand Down
9 changes: 8 additions & 1 deletion x/tx/textual/internal/testdata/tx.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,14 @@
"name": "tricky memo (starts with >, utf-8, trailing whitespaces)",
"proto": {
"body": {
"messages": [{ "@type": "/cosmos.bank.v1beta1.MsgSend", "from_address": "cosmos1ulav3hsenupswqfkw2y3sup5kgtqwnvqa8eyhs", "to_address": "cosmos1ejrf4cur2wy6kfurg9f2jppp2h3afe5h6pkh5t", "amount": [{ "denom": "uatom", "amount": "10000000" }] }],
"messages": [
{
"@type": "/cosmos.bank.v1beta1.MsgSend",
"from_address": "cosmos1ulav3hsenupswqfkw2y3sup5kgtqwnvqa8eyhs",
"to_address": "cosmos1ejrf4cur2wy6kfurg9f2jppp2h3afe5h6pkh5t",
"amount": [{ "denom": "uatom", "amount": "10000000" }]
}
],
"memo": "> ⚛️\\u269B⚛️ "
},
"auth_info": {
Expand Down