Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBC Demo #15

Closed
wants to merge 4 commits into from
Closed

IBC Demo #15

wants to merge 4 commits into from

Conversation

jaekwon
Copy link
Contributor

@jaekwon jaekwon commented Jan 29, 2017

Work in progress, feel free to comment.

@jaekwon
Copy link
Contributor Author

jaekwon commented Jan 29, 2017

We're missing is a way for other plugins to initiate an egress packet.
We should just start with a test transaction called IBCTestTx which can be signed by anyone (at first). So any user can submit an IBCTestTx to save an egress Packet of any sort.

We're also missing a way for other plugins to handle incoming packets. How can another plugin, like the TokenTransferPlugin register to "listen" for incoming "coin" packets?

We don't need an IBC coin transfer demo, but would be cool to have at least 1 packet transfer, even if it's initiated by something like IBCTestTx

}

func (ibc *IBCPlugin) StateKey() []byte {
return []byte(fmt.Sprintf("IBCPlugin.State", ibc.name))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing a formatter

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will just return []byte("IBCPlugin.State")

}

func (sm *IBCStateMachine) runRegisterChainTx(tx IBCRegisterChainTx) {
chainGenKey := toKey(_IBC, _BLOCKCHAIN, _GENESIS, chain.ChainID)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where does this chain. come from?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from tx.ChainID. Will fix.

@ebuchman
Copy link
Member

closing because obsoleted. moved notes to here https://github.com/tendermint/basecoin/issues/39

@jaekwon correct if I'm wrong

@ebuchman ebuchman closed this Feb 21, 2017
@ethanfrey ethanfrey deleted the ibc branch July 28, 2017 02:23
liamsi pushed a commit to liamsi/cosmos-sdk that referenced this pull request Jun 26, 2018
MSalopek pushed a commit to MSalopek/cosmos-sdk that referenced this pull request Jul 17, 2023
ezreal1997 pushed a commit to ezreal1997/cosmos-sdk that referenced this pull request Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants