-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBC Demo #15
Conversation
We're missing is a way for other plugins to initiate an egress packet. We're also missing a way for other plugins to handle incoming packets. How can another plugin, like the TokenTransferPlugin register to "listen" for incoming "coin" packets? We don't need an IBC coin transfer demo, but would be cool to have at least 1 packet transfer, even if it's initiated by something like IBCTestTx |
plugins/ibc/ibc.go
Outdated
} | ||
|
||
func (ibc *IBCPlugin) StateKey() []byte { | ||
return []byte(fmt.Sprintf("IBCPlugin.State", ibc.name)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing a formatter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will just return []byte("IBCPlugin.State")
plugins/ibc/ibc.go
Outdated
} | ||
|
||
func (sm *IBCStateMachine) runRegisterChainTx(tx IBCRegisterChainTx) { | ||
chainGenKey := toKey(_IBC, _BLOCKCHAIN, _GENESIS, chain.ChainID) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where does this chain.
come from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from tx.ChainID. Will fix.
closing because obsoleted. moved notes to here https://github.com/tendermint/basecoin/issues/39 @jaekwon correct if I'm wrong |
Stride LSM audit fixes
Work in progress, feel free to comment.