Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid broadcasting tx through query #15044

Merged
merged 2 commits into from
Feb 16, 2023
Merged

fix: avoid broadcasting tx through query #15044

merged 2 commits into from
Feb 16, 2023

Conversation

facundomedica
Copy link
Member

Description

Closes: #XXXX

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@facundomedica facundomedica added backport/0.45.x backport/0.46.x PR scheduled for inclusion in the v0.46's next stable release backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release labels Feb 16, 2023
@facundomedica facundomedica requested a review from a team as a code owner February 16, 2023 14:43
@facundomedica facundomedica merged commit c884e27 into main Feb 16, 2023
@facundomedica facundomedica deleted the facu/fix-query branch February 16, 2023 15:13
@mergify mergify bot mentioned this pull request Feb 16, 2023
Merged
mergify bot pushed a commit that referenced this pull request Feb 16, 2023
@facundomedica @mergify
fix: avoid broadcasting tx through query (#15044)
dd19da3 
(cherry picked from commit c884e27)
@mergify mergify bot mentioned this pull request Feb 16, 2023
Merged
mergify bot pushed a commit that referenced this pull request Feb 16, 2023
@facundomedica @mergify
fix: avoid broadcasting tx through query (#15044)
51fd981 
(cherry picked from commit c884e27)
mergify bot pushed a commit that referenced this pull request Feb 16, 2023
@facundomedica @mergify
fix: avoid broadcasting tx through query (#15044)
9c96253 
(cherry picked from commit c884e27)

# Conflicts:
#	baseapp/abci.go
@mergify mergify bot mentioned this pull request Feb 16, 2023
Merged
julienrbrt pushed a commit that referenced this pull request Feb 16, 2023
@mergify @facundomedica
fix: avoid broadcasting tx through query (backport #15044) (#15046)
fa4b6f6 
Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com>
julienrbrt added a commit that referenced this pull request Feb 16, 2023
@mergify @facundomedica @julienrbrt
fix: avoid broadcasting tx through query (backport #15044) (#15048)
140ebff 
Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
julienrbrt added a commit that referenced this pull request Feb 16, 2023
@mergify @facundomedica @julienrbrt
fix: avoid broadcasting tx through query (backport #15044) (#15047)
06406f6 
Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
SpicyLemon added a commit to provenance-io/cosmos-sdk that referenced this pull request Feb 16, 2023
@SpicyLemon @mergify
@likhita-809 @yihuang @julienrbrt @tac0turtle @mmsqe @robert-zaremba @elias-orijtech @facundomedica
Backport: #505 (v0.46.9) #517 (v0.46.10) and #510 (sanction Tx CLI) (#…
cf6f99f 
…518)

* fix: Fix Evidence CLI query flag parsing (backport cosmos#13458) (cosmos#14799)

Co-authored-by: Likhita Polavarapu <78951027+likhita-809@users.noreply.github.com>
Co-authored-by: HuangYi <huang@crypto.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>

* fix: nested iterator on cache store (cosmos#14798)

* chore: update IAVL  (backport cosmos#14830) (cosmos#14835)

Co-authored-by: Marko <marbar3778@yahoo.com>

* Mark v0.46.8-pio-2 in the changelog and release notes.

* feat: add config `iavl-lazy-loading` to enable lazy loading of iavl store (backport cosmos#14189) (cosmos#14862)

Co-authored-by: yihuang <huang@crypto.com>
Co-authored-by: marbar3778 <marbar3778@yahoo.com>

* chore: bump IAVL to v0.19.5 (backport cosmos#14889) (cosmos#14892)

Co-authored-by: Julien Robert <julien@rbrt.fr>

* build(deps): bump tendermint to v0.34.25 (cosmos#14903)

* build(deps): bump tendermint to v0.34.26 (cosmos#14911)

* fix: return named error for write validators (backport cosmos#14919) (cosmos#14921)

Co-authored-by: mmsqe <mavis@crypto.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>

* Bump Tendermint to v0.34.25 (from v0.34.24). (#498)

* Fix a few listener proto comments. (#499)

* build(deps): bump btcd in v0.46 (cosmos#14846)

Co-authored-by: yihuang <huang@crypto.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
Co-authored-by: Elias Naur <103319121+elias-orijtech@users.noreply.github.com>
Co-authored-by: Marko <marbar3778@yahoo.com>

* ci: update release slack channel and algolia api key (backport cosmos#14942) (cosmos#14945)

Co-authored-by: Julien Robert <julien@rbrt.fr>

* feat: support profiling block replay during abci handshake (backport cosmos#14953) (cosmos#14964)

Co-authored-by: yihuang <huang@crypto.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>

* Revert "Revert cosmos#14349 - cache iterator optimizations (#444)"

This reverts commit cd9d192.

* Mark v0.46.8-pio-3 in the changelog and release notes.

* fix: avoid broadcasting tx through query (backport cosmos#15044) (cosmos#15047)

Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>

* Add CLI commands for sanction Tx gov props (#510)

* Fix the changelog.

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Likhita Polavarapu <78951027+likhita-809@users.noreply.github.com>
Co-authored-by: HuangYi <huang@crypto.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
Co-authored-by: Marko <marbar3778@yahoo.com>
Co-authored-by: mmsqe <mavis@crypto.com>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Elias Naur <103319121+elias-orijtech@users.noreply.github.com>
Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com>
p0mvn pushed a commit to osmosis-labs/cosmos-sdk that referenced this pull request Feb 21, 2023
@facundomedica @p0mvn
fix: avoid broadcasting tx through query (cosmos#15044)
6c38fba
@p0mvn p0mvn mentioned this pull request Feb 21, 2023
Merged
p0mvn added a commit to osmosis-labs/cosmos-sdk that referenced this pull request Feb 22, 2023
@p0mvn
fix: avoid broadcasting tx through query (cosmos#15044) (#418)
5b0f9cf
mergify bot pushed a commit to osmosis-labs/cosmos-sdk that referenced this pull request Feb 22, 2023
@p0mvn @mergify
fix: avoid broadcasting tx through query (cosmos#15044) (#418)
2183414 
(cherry picked from commit 5b0f9cf)
julienrbrt added a commit that referenced this pull request Feb 22, 2023
@mergify @facundomedica @julienrbrt
fix: avoid broadcasting tx through query (backport #15044) (#15048)
fb5256e 
Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
ankurdotb pushed a commit to cheqd/cosmos-sdk that referenced this pull request Feb 28, 2023
@mergify @facundomedica
@julienrbrt @ankurdotb
fix: avoid broadcasting tx through query (backport cosmos#15044) (cos…
81a1ffa 
…mos#15047)

Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
p0mvn added a commit to osmosis-labs/cosmos-sdk that referenced this pull request Feb 28, 2023
@mergify @p0mvn
fix: avoid broadcasting tx through query (cosmos#15044) (#418) (#419)
44b40d4 
(cherry picked from commit 5b0f9cf)

Co-authored-by: Roman <roman@osmosis.team>
jiujiteiro pushed a commit to realiotech/cosmos-sdk that referenced this pull request Mar 7, 2023
@mergify @jiujiteiro
fix: avoid broadcasting tx through query (backport cosmos#15044) (cos…
f7623c0 
…mos#15047)

Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>

fix: create snapshot dir for rocksdb backend (backport cosmos#15054) (cosmos#15065)

Co-authored-by: yihuang <huang@crypto.com>

chore: Add check for uneven stores' height (backport cosmos#14410) (cosmos#15115)

Co-authored-by: khanh-notional <50263489+catShaark@users.noreply.github.com>
Co-authored-by: marbar3778 <marbar3778@yahoo.com>

refactor!: remove store v2alpha1 (cosmos#15152)

build: use cometbft in v0.46 (cosmos#15090)

chore: bump cometbft to v0.34.27 final (cosmos#15206)

fix: Change proposer address cast for `sdk_block` conversion (backport cosmos#15243) (cosmos#15245)

Co-authored-by: Maksym Hontar <99190705+max-hontar@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>

fix: revert double close fix (cosmos#15255)

chore: prepare v0.46.11 release (cosmos#15259)
@faddat faddat mentioned this pull request Mar 23, 2023
Closed
19 tasks
@faddat faddat mentioned this pull request Mar 28, 2023
Closed
19 tasks
@faddat faddat mentioned this pull request Dec 11, 2023
Draft
19 tasks
@0xstepit 0xstepit mentioned this pull request Jul 1, 2024
Merged
JeancarloBarrios pushed a commit to agoric-labs/cosmos-sdk that referenced this pull request Sep 28, 2024
@mergify @facundomedica
@julienrbrt @JeancarloBarrios
fix: avoid broadcasting tx through query (backport cosmos#15044) (cos…
013595c 
…mos#15048)

Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
JeancarloBarrios pushed a commit to agoric-labs/cosmos-sdk that referenced this pull request Sep 28, 2024
@mergify @facundomedica
@julienrbrt @JeancarloBarrios
fix: avoid broadcasting tx through query (backport cosmos#15044) (cos…
9fb51f0 
…mos#15047)

Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@aaronc aaronc aaronc approved these changes

@amaury1093 amaury1093 Awaiting requested review from amaury1093

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

Assignees
No one assigned
Labels
backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release backport/0.46.x PR scheduled for inclusion in the v0.46's next stable release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@facundomedica @aaronc @julienrbrt