feat: constitution #15125
feat: constitution #15125
Conversation
github-prbot
requested review from
a team,
facundomedica and
likhita-809
and removed request for
a team
x/gov/types/keys.go
Outdated
| @@ -49,6 +49,9 @@ var ( | |||
|
|
|||
| // ParamsKey is the key to query all gov params | |||
| ParamsKey = []byte{0x30} | |||
|
|
|||
| // KeyConstitution is the key string used to store the chain's constitution | |||
| KeyConstitution = "constitution" | |||
There was a problem hiding this comment.
nit: convert that key to byte directly here, as keys are always in []byte.
There was a problem hiding this comment.
we could use collections Item here and avoid the boilerplate?
x/gov/client/cli/query_test.go
Outdated
| "1", | ||
| fmt.Sprintf("--%s=json", flags.FlagOutput), | ||
| }, | ||
| "1 --output=json", |
There was a problem hiding this comment.
There is no argument output supported by the command constitution, so ti should actually fail
There was a problem hiding this comment.
This test isnt supposed to be in there actually. Its a copy of the other but wrong lol
There was a problem hiding this comment.
Okay, maybe it could be nice to add that output flag and display it as json too. I believe most commands of gov allow that, so imo this one too.
| @@ -18,6 +18,13 @@ import ( | |||
|
|
|||
| var _ v1.QueryServer = Keeper{} | |||
|
|
|||
| func (q Keeper) Constitution(c context.Context, req *v1.QueryConstitutionRequest) (*v1.QueryConstitutionResponse, error) { | |||
There was a problem hiding this comment.
nit: this does not need to return an error as no function returns an error.
Description
Closes: #14065
Picked commits from #14373 for constitution on gov with additions
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change