-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove capability module #15344
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! we should add section to the UPGRADING.md (### Modules section) and remove it from here: https://github.com/cosmos/cosmos-sdk/tree/main/x#readme
@@ -252,13 +252,6 @@ const config = { | |||
], | |||
to: "/main/modules/bank", | |||
}, | |||
{ | |||
from: [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As Marko mentioned, when IBC has a link about capability's readme (after cosmos/ibc-go#3097 is merged). We should redirect these links and /main/modules/capability
to the readme (https://github.com/cosmos/ibc-go/blob/marko/capability/capability/README.md but pointing to the main branch then)
Description
removes capability module since it will ive in ibc-go for 0.48
cosmos/ibc-go#3097
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change