Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add extra check in vesting (backport #15373) #15383

Merged
merged 3 commits into from
Mar 14, 2023
Merged

fix: add extra check in vesting (backport #15373) #15383

merged 3 commits into from
Mar 14, 2023

Commits on Mar 14, 2023

  1. fix: add extra check in vesting (#15373) 

    ## Description

Closes: #XXXX

---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)

(cherry picked from commit 721c24a)

# Conflicts:
#	x/auth/testutil/expected_keepers_mocks.go
#	x/auth/vesting/msg_server_test.go
    @julienrbrt @mergify
    julienrbrt authored and mergify[bot] committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    a36c1a4 View commit details
    Browse the repository at this point in the history

  2. fix conflicts

    @julienrbrt
    julienrbrt committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    0c5ab5e View commit details
    Browse the repository at this point in the history

  3. add changelog

    @julienrbrt
    julienrbrt committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    eecf548 View commit details
    Browse the repository at this point in the history