Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style Linting #6 #15628

Closed
wants to merge 16 commits into from
Closed

Style Linting #6 #15628

wants to merge 16 commits into from

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Mar 30, 2023

  • ensure changes
  • remove new linters
  • revert changes to .golangci.yml
  • revert orm errors
  • disable ifElseChain
  • don't check appendAssign
  • fix orm
  • remove a check on switch statements

Description

This contains "some more linting changes"


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@faddat faddat requested a review from a team as a code owner March 30, 2023 15:20
@mergify
Copy link
Contributor

mergify bot commented Mar 30, 2023

⚠️ The sha of the head commit of this PR conflicts with #15610. Mergify cannot evaluate rules on this PR. ⚠️

@github-prbot github-prbot requested review from a team, kocubinski and alexanderbez and removed request for a team March 30, 2023 15:21
@faddat
Copy link
Contributor Author

faddat commented Mar 30, 2023

note: not a dupe

@faddat faddat changed the title Linting #6 (including reductive settings) Style Linting #6 (including reductive settings) Mar 30, 2023
@faddat faddat changed the title Style Linting #6 (including reductive settings) Style Linting #6 Mar 30, 2023
@faddat faddat mentioned this pull request Mar 30, 2023
19 tasks
@faddat faddat closed this Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant