Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: everything linted #15632

Closed
wants to merge 62 commits into from
Closed

style: everything linted #15632

wants to merge 62 commits into from

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Mar 30, 2023

Description

Please do not review this PR. It is for my personal reference,
to judge the size of remaining changes.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@faddat
Copy link
Contributor Author

faddat commented Mar 30, 2023

@julienrbrt I'm also trying to use it to figure out where those periods are coming from.

If I recall correctly, though, I noticed an issue with them also and disabled .... something mid-stream during orm. Actually easier fix is likely to close #15610, fix everything in the PR you must not view, and then break modules out of there one by one.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gosec found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

@github-actions github-actions bot added C:collections C:Confix Issues and PR related to Confix C:log C:Rosetta Issues and PR related to Rosetta C:x/upgrade labels Mar 30, 2023
@faddat
Copy link
Contributor Author

faddat commented Mar 31, 2023

bad branch

@faddat faddat closed this Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants