Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(store): add working hash #15712

Merged
merged 19 commits into from
Apr 13, 2023
Merged

feat(store): add working hash #15712

merged 19 commits into from
Apr 13, 2023

Conversation

cool-develope
Copy link
Contributor

Description

Closes: #15687


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@cool-develope cool-develope requested a review from a team as a code owner April 5, 2023 20:55
@github-actions

This comment has been minimized.

@cool-develope cool-develope changed the title feat: add working hash feat(store): add working hash Apr 5, 2023
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TYSM

store/rootmulti/store.go Outdated Show resolved Hide resolved
store/rootmulti/store.go Outdated Show resolved Hide resolved
store/transient/store.go Outdated Show resolved Hide resolved
store/rootmulti/store.go Outdated Show resolved Hide resolved
store/iavl/store.go Outdated Show resolved Hide resolved
cool-develope and others added 3 commits April 6, 2023 10:03
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Copy link
Member

@mark-rushakoff mark-rushakoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two style suggestions, but otherwise I think this is fine.

store/rootmulti/store.go Outdated Show resolved Hide resolved
store/rootmulti/store.go Outdated Show resolved Hide resolved
@itsdevbear
Copy link
Contributor

itsdevbear commented Apr 9, 2023

@tac0turtle my IntermediateRootHash issue is solved (sorta, but not really).

ty ty @cool-develope

Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally looks good to me, lets get a changelog entry and left one questin

@tac0turtle tac0turtle enabled auto-merge (squash) April 11, 2023 09:38
store/CHANGELOG.md Outdated Show resolved Hide resolved
store/transient/store.go Outdated Show resolved Hide resolved
store/transient/store.go Outdated Show resolved Hide resolved
store/CHANGELOG.md Outdated Show resolved Hide resolved
@itsdevbear
Copy link
Contributor

Is it possible to have a CacheKV be able to see its WorkingHash, this would be incredibly useful for the IntermediateStateRoot in https://github.com/Berachain/polaris

@yihuang can we use memiavl here maybe?

@tac0turtle
Copy link
Member

Is it possible to have a CacheKV be able to see its WorkingHash, this would be incredibly useful for the IntermediateStateRoot in https://github.com/Berachain/polaris

@yihuang can we use memiavl here maybe?

i would say not in the iteration, lets open an issue on this as its also needed for rollkit fraudproof stuff. Trying to keep this pr scoped

@tac0turtle tac0turtle enabled auto-merge (squash) April 12, 2023 21:42
@julienrbrt julienrbrt added the A:automerge Automatically merge PR once all prerequisites pass. label Apr 13, 2023
@tac0turtle tac0turtle merged commit 56705de into main Apr 13, 2023
@tac0turtle tac0turtle deleted the 15687/store_workinghash branch April 13, 2023 09:18
cool-develope added a commit that referenced this pull request Apr 26, 2023
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Marko <marbar3778@yahoo.com>
cool-develope added a commit that referenced this pull request Apr 26, 2023
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Marko <marbar3778@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:Store
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: rollback store version based off of abci handshake
6 participants