build(deps): bump cosmossdk.io/core to v0.5.1

[faddat]

Description

This PR bumps cosmossdk.io/core in sdk 47 because ibc-go is using a newer one, and this was causing integration difficulties.

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• followed the guidelines for building modules
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

[julienrbrt]

Blocking this, until clarity on what are precisely the issues you are encountering.
Core has no implementation, so I am very curious about what error you are getting.
git difftool core/v0.3.2 core/v0.5.1 core/ shows no breaking changes.

[faddat]

It is cool, it could be a day or two for me because I travel today.

It is an issue with having the right versions when go getting stuff in go.mod. it'll downgrade one thing, etc.

No worries on blocking it I will make a video sir

@julienbrt

hey, I have something better than a video:

go get cosmossdk.io/core@v0.3.2 
go: downgraded cosmossdk.io/core v0.5.1 => v0.3.2
go: removed cosmossdk.io/simapp v0.0.0-20230224204036-a6adb0821462
go: removed cosmossdk.io/tools/rosetta v0.2.1
go: downgraded github.com/CosmWasm/wasmd v0.40.0-rc.1.0.20230422061626-b85abcf1d7b8 => v0.31.0-rc0
go: removed github.com/CosmosContracts/juno/v15/osmoutils v0.0.0-00010101000000-000000000000
go: downgraded github.com/cosmos/cosmos-sdk v0.47.1 => v0.46.12
go: removed github.com/cosmos/ibc-go/v7 v7.0.0
go: removed github.com/strangelove-ventures/async-icq/v7 v7.0.0-20230413165143-a3b65ccdc897
go: removed github.com/strangelove-ventures/packet-forward-middleware/v7 v7.0.0-20230412224111-136e94e98861

If we could possibly get this into the new 47.2 that would be super -- I agree with you that there aren't breaking changes, this is mainly a developer experience improvement. One upgrade challenge is getting go.sum to behave well,

[julienrbrt]

Thanks for the answer. Could you tell us when it happens? I see you are doing a go get, and it downgrades the go.mod dependencies.
Do you have any other module requiring v0.5.1 in the chain you are trying to upgrade?

[faddat]

Yeah man, what I was doing is upgrading Juno. When you are writing a chain upgrade, it can be difficult time consuming to get all the different versions in go.mod to match.

It looks like IBC and WASMD both require at minimum 0.5.1.

[faddat]

Yeah man, what I was doing is upgrading Juno. When you are writing a chain upgrade, it can be difficult time consuming to get all the different versions in go.mod to match.

It looks like IBC and WASMD both require at minimum 0.5.1.

[tac0turtle]

the reason you get downgraded but it still works is because go will downgrade to match other versions until there is a breaking change. This pr is cosmetic for go get imo. There are no issues with you using 0.3.x. IBC has a indirect dependency so you using 0.3.x is safe. There isnt a need to bump this version imo. It doesnt add any value then fixing one line in go get.

@julienrbrt its up to you if you want to merge this

[julienrbrt]

I think still it does not matter, but given there are no breaking changes, we can just bump it yeah.