fix: unique constraint violation for group policy sim genesis

[gjermundgaraba]

Description

Closes: #15741

Checks if the group policy address has been used already, skip or retry if it has been used already.

I didn't add a changelog nor any additional tests, but if you want those things too, I would be happy to do so.

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• followed the guidelines for building modules
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

[julienrbrt]

Thank you! I think, as noted in the issue, we should as well remove the seed override.

[gjermundgaraba]

Thank you! I think, as noted in the issue, we should as well remove the seed override.

Remove the seed override? Do you mean something like checking if the seed(s) is set in the flag use that instead of the random seed?

config.Seed = rand.Int63()

Or do you mean not making it random anymore at all?

[julienrbrt]

Thank you! I think, as noted in the issue, we should as well remove the seed override.

Remove the seed override? Do you mean something like checking if the seed(s) is set in the flag use that instead of the random seed?

config.Seed = rand.Int63()

Or do you mean not making it random anymore at all?

Yea, the first one. It was pretty confusing the seed passed was getting overwritten.

[gjermundgaraba]

Makes sense, should I just check if the value is not set to the default value (move 42 into a const) and then only run 1 round on that seed (rather than 3 times on the same seed/other random seeds)?

flag.Int64Var(&FlagSeedValue, "Seed", 42, "simulation random seed")

[julienrbrt]

Makes sense, should I just check if the value is not set to the default value (move 42 into a const) and then only run 1 round on that seed (rather than 3 times on the same seed/other random seeds)?

flag.Int64Var(&FlagSeedValue, "Seed", 42, "simulation random seed")

Sounds good!

[alexanderbez]

What's the rationale for these changes?

[julienrbrt]

The rationale is that there was confusion about what runsim outputs as seed and the seed that test is actually using (#14833)