refactor(core): use working hash in finalizeblock instead of flush #16065
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -166,7 +166,7 @@ | |||
|
|
|||
| // commit genesis changes | |||
| if !startupConfig.AtGenesis { | |||
| // app.Commit(context.TODO(), &abci.RequestCommit{}) // TODO figure out if this is needed? | |||
| app.Commit(context.TODO(), &abci.RequestCommit{}) | |||
Check warning
Code scanning / gosec
Errors unhandled.
| // state transitions will be flushed to disk and as a result, but we already have | ||
| // an application Merkle root. | ||
| func (app *BaseApp) workingHash() []byte { | ||
| app.finalizeBlockState.ms.Write() |
There was a problem hiding this comment.
What's the reason for this call?
There was a problem hiding this comment.
since we moved the writing from comit to working hash now after Initchain & commit are called there is still no state, so we need to write to disk in order to call commit
There was a problem hiding this comment.
I think it's still a misnomer to call this workingHash as the name implies it's idempotent. But in reality, this now has side affects. Perhaps consider moving the flush/write to disk back to Commit.
baseapp/abci.go
Outdated
| func (app *BaseApp) flushCommit() storetypes.CommitID { | ||
| app.finalizeBlockState.ms.Write() | ||
|
|
There was a problem hiding this comment.
the name of flashCommit doesn't make sense since get rid of Write, ?
There was a problem hiding this comment.
ill change to commit to make it clearer, thanks for the pointer
Description
ref #12272
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change