perf: Remove indentation in REST respones #16142
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The GRPC-to-REST gateway converts protobuf responses to JSON. However the marshalling we use for this adds indentation, consuming unnecessary bandwidth for all FE users. I believe I was told that indentation was getting to 20% of bandwidth on queries to full nodes from app.osmosis.zone.
This PR just stops sending the whitespace here.
I believe this is non-breaking, because I'm unaware of any consumer of JSON content, that would break from removal of whitespace.
This shouldn't add debugging overhead, as every browser comes with great JSON viewers, that work independent of the whitespacing.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change