chore: finish TODO of removing defunct sortJSON #16401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@odeke-em your pull request is missing a changelog! |
julienrbrt
changed the title
|
minor lint issue otherwise looks good, once we get the lint issue resolved we can merge |
odeke-em
force-pushed
the
remove-defunct-soortJSON
branch
from
b5bdfe2
to
1e9a8a4
Compare
tac0turtle
approved these changes
Jun 7, 2023
odeke-em
force-pushed
the
remove-defunct-soortJSON
branch
from
1e9a8a4
to
f97d394
Compare
julienrbrt
added
the
backport/v0.50.x
mergify bot
pushed a commit
that referenced
this pull request
Jun 10, 2023
(cherry picked from commit 3db9528)
tac0turtle
pushed a commit
that referenced
this pull request
Jun 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes PR #16062 by removing sortJSON now that aminojson.Encoder sorts fields by default. sortJSON was left as a TODO
Updates #2350
Updates #16254