chore: properly propagate fmt.Errorf errors + use errors.New #16537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:CLI
C:Confix
This comment has been minimized.
This comment has been minimized.
odeke-em
force-pushed
the
all-propagate+properly-wrap-errors-in-fmt.Errorf
branch
from
811db3e
to
c49f24a
Compare
julienrbrt
approved these changes
Jun 14, 2023
CHANGELOG.md
Outdated
| @@ -40,7 +40,8 @@ Ref: https://keepachangelog.com/en/1.0.0/ | |||
|
|
|||
| ### Improvements | |||
|
|
|||
| * (all) [#16497](https://github.com/cosmos/cosmos-sdk/pull/16497) Removed all exported vestiges of `sdk.MustSortJSON` and `sdk.SortJSON`. | |||
| * (all) [#16537](https://github.com/cosmos/cosmos-sdk/pull/16497) Removed all exported vestiges of `sdk.MustSortJSON` and `sdk.SortJSON`. | |||
| * (all) [#16497](https://github.com/cosmos/cosmos-sdk/pull/16537) Properly propagated fmt.Errorf errors + using errors.New where appropriate. | |||
There was a problem hiding this comment.
The pr numbers seem to be inverted
There was a problem hiding this comment.
I still they are still inverted.
julienrbrt
changed the title
alexanderbez
approved these changes
Jun 14, 2023
odeke-em
force-pushed
the
all-propagate+properly-wrap-errors-in-fmt.Errorf
branch
2 times, most recently
from
d1a7b10
to
484b30e
Compare
|
Thanks for the reviews @julienrbrt and @alexanderbez! |
|
one more linting issue then we are good. Thanks for sticking through this |
Changes usages of fmt.Errorf that tried to propagate
errors using format specifiers "%s" or "%v", and unnecessarily
invoked err.Error() to pass into "%s"
While here, replaced some instances of
fmt.Errorf(string)
with
errors.New(string)
Fixes #16536
odeke-em
force-pushed
the
all-propagate+properly-wrap-errors-in-fmt.Errorf
branch
from
484b30e
to
fe41652
Compare
|
Thanks for the reviews @tac0turtle @facundomedica @julienrbrt @alexanderbez. All good to go shortly! |
|
the test failure need to be button upped |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes usages of fmt.Errorf that tried to propagate errors using format specifiers "%s" or "%v", and unnecessarily invoked err.Error() to pass into "%s"
While here, replaced some instances of
with
Fixes #16536