Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(evidence): autocli query support #16625

Merged
merged 2 commits into from
Jun 20, 2023
Merged

feat(evidence): autocli query support #16625

merged 2 commits into from
Jun 20, 2023

Conversation

julienrbrt
Copy link
Member

Description

ref #15901

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt requested a review from a team as a code owner June 20, 2023 16:44
@julienrbrt julienrbrt mentioned this pull request Jun 20, 2023
Closed
17 tasks
@julienrbrt julienrbrt added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Jun 20, 2023
JeancarloBarrios
JeancarloBarrios approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@JeancarloBarrios JeancarloBarrios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@julienrbrt julienrbrt added this pull request to the merge queue Jun 20, 2023
Merged via the queue into main with commit cf842f9 Jun 20, 2023
@julienrbrt julienrbrt deleted the julien/autocli-evidence branch June 20, 2023 19:34
mergify bot pushed a commit that referenced this pull request Jun 20, 2023
@julienrbrt @mergify
feat(evidence): autocli query support (#16625)
2f2ad76 
(cherry picked from commit cf842f9)

# Conflicts:
#	x/evidence/go.mod
#	x/evidence/go.sum
@mergify mergify bot mentioned this pull request Jun 20, 2023
Merged
julienrbrt added a commit that referenced this pull request Jun 21, 2023
@mergify @julienrbrt
feat(evidence): autocli query support (backport #16625) (#16629)
179c6c7 
Co-authored-by: Julien Robert <julien@rbrt.fr>
This was referenced Apr 22, 2024
Merged
Merged
@coderabbitai coderabbitai bot mentioned this pull request May 3, 2024
Merged
12 tasks
@faddat faddat mentioned this pull request Nov 8, 2024
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeancarloBarrios JeancarloBarrios JeancarloBarrios approved these changes

@aaronc aaronc Awaiting requested review from aaronc

@atheeshp atheeshp Awaiting requested review from atheeshp

Assignees
No one assigned
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:CLI C:x/evidence
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julienrbrt @JeancarloBarrios