Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pagination issue in collection paginate #16661

Closed
wants to merge 4 commits into from

Conversation

atheeshp
Copy link
Contributor

@atheeshp atheeshp commented Jun 23, 2023

Problem

The Count value in pagination response is wrong (currently including all the records from state instead of counting only the matched records)

Description

For example:
Assume these are the five grants exist in state

[
	{
		"grantee": "granteeAddr1",
		"granter": "granterAddr1"
	},
	{
		"grantee": "granteeAddr2",
		"granter": "granterAddr1"
	},
	{
		"grantee": "granteeAddr3",
		"granter": "granterAddr1"
	},
	{
		"grantee": "granteeAddr4",
		"granter": "granterAddr1"
	},
	{
		"grantee": "granteeAddr5",
		"granter": "granterAddr2"
	},
]

I want to query the grants by granter address (where the key structure is key collections.Pair[grantee, granter]), the possible solution is to iterate all grants and match the key.Key2() (which is granter address) with the given input.

I am doing the same here, but the problem is the total count in the pagination response is 5 instead of 1 when I query it with granterAddr2 (granterAddr2 has only 1 grant exist in the state)

also check the thread here: https://github.com/cosmos/cosmos-sdk/pull/16535/files#r1235146107


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@odeke-em
Copy link
Collaborator

Thank you @atheeshp. Just a drive-by code review. Could you please describe in words what exactly the issue is? This will massively help in giving context to other maintainers and to future selves. Thank you.

@atheeshp
Copy link
Contributor Author

Thank you @atheeshp. Just a drive-by code review. Could you please describe in words what exactly the issue is? This will massively help in giving context to other maintainers and to future selves. Thank you.

Hey @odeke-em , sorry for missing the context here. Just updated the PR description. Thanks.

@julienrbrt julienrbrt added R:Eden backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release labels Jun 30, 2023
@tac0turtle
Copy link
Member

super seeded by #16905

@tac0turtle tac0turtle closed this Jul 17, 2023
@tac0turtle tac0turtle deleted the ap/fix-collection-pagination branch February 21, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:x/gov
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants