fix: pagination issue in collection paginate #16661
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
Count
value in pagination response is wrong (currently including all the records from state instead of counting only the matched records)Description
For example:
Assume these are the five grants exist in state
I want to query the grants by granter address (where the key structure is
key collections.Pair[grantee, granter]
), the possible solution is to iterate all grants and match the key.Key2() (which is granter address) with the given input.I am doing the same here, but the problem is the total count in the pagination response is 5 instead of 1 when I query it with
granterAddr2
(granterAddr2
has only 1 grant exist in the state)also check the thread here: https://github.com/cosmos/cosmos-sdk/pull/16535/files#r1235146107
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change