Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(x/slashing): Emit slashing event with the correct reason in SlashWithInfractionReason #16784

Merged
merged 4 commits into from
Jun 30, 2023
Merged

fix(x/slashing): Emit slashing event with the correct reason in SlashWithInfractionReason #16784

merged 4 commits into from
Jun 30, 2023

Conversation

facundomedica
Copy link
Member

@facundomedica facundomedica commented Jun 30, 2023 •
edited
Loading

Description

Before this all events were emitted as being double signs. I'm not sure if we would like to backport this 🤔

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@facundomedica facundomedica marked this pull request as ready for review June 30, 2023 07:35
@facundomedica facundomedica requested review from a team as code owners June 30, 2023 07:35
@github-actions

This comment has been minimized.

Sign in to view
@facundomedica facundomedica changed the title fix(x/slashing): Emit slashing event with the correct reason fix(x/slashing): Emit slashing event with the correct reason in SlashWithInfractionReason Jun 30, 2023
julienrbrt
julienrbrt approved these changes Jun 30, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@julienrbrt julienrbrt added backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release labels Jun 30, 2023
likhita-809
likhita-809 approved these changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@likhita-809 likhita-809 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice find!

@julienrbrt julienrbrt added this pull request to the merge queue Jun 30, 2023
Merged via the queue into main with commit 3702dfc Jun 30, 2023
@julienrbrt julienrbrt deleted the facu/fix-slash-evt branch June 30, 2023 10:47
mergify bot pushed a commit that referenced this pull request Jun 30, 2023
@facundomedica @mergify
fix(x/slashing): Emit slashing event with the correct reason in Slash…
deae141 
…WithInfractionReason (#16784)

(cherry picked from commit 3702dfc)

# Conflicts:
#	CHANGELOG.md
@mergify mergify bot mentioned this pull request Jun 30, 2023
Merged
mergify bot pushed a commit that referenced this pull request Jun 30, 2023
@facundomedica @mergify
fix(x/slashing): Emit slashing event with the correct reason in Slash…
e9e26f8 
…WithInfractionReason (#16784)

(cherry picked from commit 3702dfc)

# Conflicts:
#	CHANGELOG.md
#	x/slashing/keeper/keeper.go
@mergify mergify bot mentioned this pull request Jun 30, 2023
Merged
julienrbrt added a commit that referenced this pull request Jun 30, 2023
@mergify @facundomedica @julienrbrt
fix(x/slashing): Emit slashing event with the correct reason in Slash…
ce08c79 
…WithInfractionReason (backport #16784) (#16792)

Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
julienrbrt pushed a commit that referenced this pull request Jun 30, 2023
@mergify
fix(x/slashing): Emit slashing event with the correct reason in Slash…
398214f 
…WithInfractionReason (backport #16784) (#16793)
@jacksoom jacksoom mentioned this pull request Jul 29, 2023
Merged
@0xstepit 0xstepit mentioned this pull request Jul 1, 2024
Merged
@faddat faddat mentioned this pull request Nov 8, 2024
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@likhita-809 likhita-809 likhita-809 approved these changes

@julienrbrt julienrbrt julienrbrt approved these changes

@kocubinski kocubinski Awaiting requested review from kocubinski

Assignees
No one assigned
Labels
backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:x/slashing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@facundomedica @julienrbrt @likhita-809