Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release/v0.21.1 #1683

Merged
merged 3 commits into from
Jul 16, 2018
Merged

Release/v0.21.1 #1683

merged 3 commits into from
Jul 16, 2018

Conversation

cwgoes
Copy link
Contributor

@cwgoes cwgoes commented Jul 14, 2018

  • Updated all relevant documentation (docs/)
  • Updated all relevant code comments
  • Wrote tests
  • Updated CHANGELOG.md
  • Updated cmd/gaia and examples/

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@cwgoes cwgoes mentioned this pull request Jul 14, 2018
Merged
8 tasks
alexanderbez and others added 2 commits July 14, 2018 04:19
@alexanderbez @cwgoes
Fix Cross Compile Build/Ledger Build Tag (#1674)
db7407f 
* Merge pull request #1674: Fix Cross Compile Build/Ledger Build Tag
* Merge pull request #1674: Fix Cross Compile Build/Ledger Build Tag
* Remove incorrect Ledger test
@cwgoes
Version & changelog
28a1b5e
@cwgoes
Copy link
Contributor Author

cwgoes commented Jul 14, 2018

Huh, the "Files changed" tab on Github seems wrong, it has no correlation with git diff master locally.

All this PR does is cherry-pick bb1f1a2.

@codecov
Copy link

codecov bot commented Jul 14, 2018 •
edited
Loading

Codecov Report

Merging #1683 into master will decrease coverage by 1.39%.
The diff coverage is 10%.

@@            Coverage Diff            @@
##           master    #1683     +/-   ##
=========================================
- Coverage   62.05%   60.66%   -1.4%     
=========================================
  Files         116      119      +3     
  Lines        6931     6904     -27     
=========================================
- Hits         4301     4188    -113     
- Misses       2387     2477     +90     
+ Partials      243      239      -4

@faboweb faboweb mentioned this pull request Jul 16, 2018
Merged
@ebuchman
Copy link
Member

tagged as v0.21.1

@ebuchman ebuchman merged commit e38aac5 into master Jul 16, 2018
@ebuchman ebuchman deleted the release/v0.21.1 branch July 16, 2018 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebuchman ebuchman Awaiting requested review from ebuchman

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cwgoes @ebuchman @alexanderbez