Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to tm0.22.4-rc0 and bring back lcd test #1685

Merged
merged 2 commits into from
Jul 16, 2018
Merged

Conversation

ebuchman
Copy link
Member

  • Updated all relevant documentation (docs/)
  • Updated all relevant code comments
  • Wrote tests
  • Updated CHANGELOG.md
  • Updated cmd/gaia and examples/

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@ebuchman
Copy link
Member Author

Failed with:

--- FAIL: TestBonding (3.91s)
I[07-14|12:31:15.411] Address handler done                         module=p2p book=/home/circleci/.tendermint_test/_go_src_github.com_cosmos_cosmos-sdk_client_lcd/config/addrbook.json
E[07-14|12:31:15.411] RPC HTTP server stopped                      err="accept tcp [::]:39459: use of closed network connection"
	assertions.go:247: 
                          
	Error Trace:	lcd_test.go:786
		
	            	
			lcd_test.go:412
		
	Error:      	Not equal: 
		
	            	expected: 200
		
	            	actual  : 500
		
	Test:       	TestBonding
		
	Messages:   	checkTx failed: (65548) === ABCI Log ===
		
	            	Codespace: 1
		
	            	Code:      12
		
	            	ABCICode:  65548
		
	            	Error:     --= Error =--
		
	            	Data: common.FmtError{format:"out of gas in location: SetPerByte", args:[]interface {}(nil)}
		
	            	Msg Traces:
		
	            	--= /Error =--
		
	            	
		
	            	=== /ABCI Log ===

Not sure how this happens. Passes locally. But somehow out-of-gas non-deterministically?!

@ebuchman
Copy link
Member Author

Fails reliably locally with same error when using -race

@codecov
Copy link

codecov bot commented Jul 14, 2018

Codecov Report

Merging #1685 into master will increase coverage by 0.31%.
The diff coverage is 80%.

@@            Coverage Diff             @@
##           master    #1685      +/-   ##
==========================================
+ Coverage   62.07%   62.38%   +0.31%     
==========================================
  Files         116      120       +4     
  Lines        6929     7115     +186     
==========================================
+ Hits         4301     4439     +138     
- Misses       2385     2425      +40     
- Partials      243      251       +8

@ebuchman ebuchman merged commit 90ed178 into master Jul 16, 2018
@ebuchman ebuchman deleted the bucky/fix-lcd-tests branch July 16, 2018 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant